Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
build,win: fix node.exe resource version
When MSBuild invokes rc.exe, it passes NODE_TAG unstringified, but
passes it correctly to cl.exe. Hence, this workaround was made to
apply only to the resource file.

Fixes: #2963
PR-URL: #3053
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
  • Loading branch information
joaocgreis authored and rvagg committed Nov 24, 2015
commit 7e4b47f38af90674317e95be38dc26051f57571a
4 changes: 2 additions & 2 deletions src/res/node.rc
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ BEGIN
VALUE "CompanyName", "Joyent, Inc"
VALUE "ProductName", "Node.js"
VALUE "FileDescription", "Evented I/O for V8 JavaScript"
VALUE "FileVersion", NODE_VERSION_STRING
VALUE "ProductVersion", NODE_VERSION_STRING
VALUE "FileVersion", NODE_EXE_VERSION
VALUE "ProductVersion", NODE_EXE_VERSION
VALUE "OriginalFilename", "node.exe"
VALUE "InternalName", "node"
VALUE "LegalCopyright", "Copyright Joyent, Inc. and other Node contributors. MIT license."
Expand Down