Skip to content

test: fix test-linux-perf #28048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 1 commit into from
Closed

test: fix test-linux-perf #28048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix test-linux-perf 
- Set maxBuffer to Infinity because the output can exceed 1MB.
- Fix error checking for perfScript
  • Loading branch information
@targos
targos committed Jun 4, 2019
commit 289009fd655da6d898de7aed76ed870e161a646f
5 changes: 3 additions & 2 deletions test/v8-updates/test-linux-perf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ const perfScriptArgs = [
const options = {
cwd: tmpdir.path,
encoding: 'utf-8',
maxBuffer: Infinity
};

if (!common.isLinux)
Expand All @@ -57,8 +58,8 @@ if (perf.status !== 0) {

const perfScript = spawnSync('perf', perfScriptArgs, options);

if (perf.error)
common.skip(`perf script aborted: ${perf.error.errno}`);
if (perfScript.error)
common.skip(`perf script aborted: ${perfScript.error.errno}`);

if (perfScript.status !== 0) {
common.skip(`Failed to execute perf script: ${perfScript.stderr}`);
Expand Down