Skip to content

events: add EventEmitter.on to async iterate over events #27994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcollina wants to merge 17 commits into from
Closed

events: add EventEmitter.on to async iterate over events #27994

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
fb4052a
events: add EventEmitter.on to async iterate over events
mcollina May 30, 2019
0a1b52d
Update lib/events.js
mcollina Dec 20, 2019
31bb823
Update lib/events.js
mcollina Dec 20, 2019
c795045
Update lib/events.js
mcollina Dec 20, 2019
7344bf7
Update lib/events.js
mcollina Dec 20, 2019
c8b16cf
Update lib/events.js
mcollina Dec 20, 2019
4542f50
Update test/parallel/test-event-on-async-iterator.js
mcollina Dec 20, 2019
10821a2
Update test/parallel/test-event-on-async-iterator.js
mcollina Dec 20, 2019
b71f016
fixup: passing tests
mcollina Dec 20, 2019
0c38799
fixup: docs updates
mcollina Dec 20, 2019
0e9b7fa
fixup: more feedback
mcollina Dec 20, 2019
f1babd5
fixup: reviews
mcollina Dec 20, 2019
2e9ffee
fixup: address comments
mcollina Dec 20, 2019
346fa56
fixup: linting
mcollina Dec 21, 2019
0e518be
fixup: fix tests after rebase:
mcollina Dec 22, 2019
c7cda01
Update doc/api/events.md
mcollina Dec 22, 2019
35939a5
Update doc/api/events.md
mcollina Dec 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: fix tests after rebase:
  • Loading branch information
@mcollina
mcollina committed Dec 22, 2019
commit 0e518be387796a2744eda7953c88b889dbfea13e
2 changes: 1 addition & 1 deletion test/parallel/test-event-on-async-iterator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ async function iterableThrow() {
iterable.throw();
}, {
message: 'The "EventEmitter.AsyncIterator" property must be' +
' of type Error. Received type undefined',
' an instance of Error. Received undefined',
name: 'TypeError'
});

Expand Down