Skip to content

http2: Prevent unnecessary listeners from being registered #27987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akukas wants to merge 6 commits into from
Closed

http2: Prevent unnecessary listeners from being registered #27987

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8a20754
http2: don't register unnecessary listeners
akukas May 30, 2019
02dec4b
test
akukas May 30, 2019
2cf97f2
Use a symbol instead of an underscore prefix
akukas May 30, 2019
72c1cd1
Fix linter errors
akukas May 30, 2019
f46ba03
Fix linter errors
akukas May 30, 2019
0538297
Minor changes
akukas May 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use a symbol instead of an underscore prefix
  • Loading branch information
@akukas
akukas authored May 30, 2019
commit 2cf97f23e808077c2bad12e48ef49ff373163d5b
11 changes: 6 additions & 5 deletions lib/internal/http2/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ const kLocalSettings = Symbol('local-settings');
const kOptions = Symbol('options');
const kOwner = owner_symbol;
const kOrigin = Symbol('origin');
const kPendingRequestCalls = Symbol('pending-request-calls');
Comment thread
akukas marked this conversation as resolved.
Outdated
const kProceed = Symbol('proceed');
const kProtocol = Symbol('protocol');
const kRemoteSettings = Symbol('remote-settings');
Expand Down Expand Up @@ -1479,13 +1480,13 @@ class ClientHttp2Session extends Http2Session {

const onConnect = requestOnConnect.bind(stream, headersList, options);
if (this.connecting) {
if (this._pendingRequestCalls) {
this._pendingRequestCalls.push(onConnect);
if (this[kPendingRequestCalls]) {
Comment thread
akukas marked this conversation as resolved.
Outdated
this[kPendingRequestCalls].push(onConnect);
} else {
this._pendingRequestCalls = [onConnect];
this[kPendingRequestCalls] = [onConnect];
this.once('connect', () => {
this._pendingRequestCalls.forEach(f => f());
delete this._pendingRequestCalls;
this[kPendingRequestCalls].forEach(f => f());
delete this[kPendingRequestCalls];
Comment thread
akukas marked this conversation as resolved.
Outdated
});
}
} else {
Expand Down