Skip to content

doc: warn about relying on fs gc close behavior #27972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benjamingr wants to merge 3 commits into from
Closed

doc: warn about relying on fs gc close behavior #27972

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcdb522
doc: warn about relying on fs gc close behavior
benjamingr May 30, 2019
6b39707
Update doc/api/fs.md
benjamingr May 30, 2019
eefdd6e
Update doc/api/fs.md
benjamingr May 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update doc/api/fs.md 
Co-Authored-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
@benjamingr @Trott
benjamingr and Trott authored May 30, 2019
commit eefdd6edf33803fc74632827240a2a7eba3aa291
2 changes: 1 addition & 1 deletion doc/api/fs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3736,7 +3736,7 @@ Instances of `FileHandle` are distinct from numeric file descriptors
in that they provide an object oriented API for working with files.

If a `FileHandle` is not closed using the
`filehandle.close()` method, they might automatically close the file descriptor
`filehandle.close()` method, it might automatically close the file descriptor
and will emit a process warning, thereby helping to prevent memory leaks.
Please do not rely on this behavior in your code because it is unreliable and
your file may not be closed. Instead, always explicitly close `FileHandle`s.
Expand Down