Skip to content

test: fix arguments order of comparsion functions #27907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChALkeR merged 1 commit into from
May 27, 2019
Merged

test: fix arguments order of comparsion functions #27907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix arguments order of comparsion functions 
Place actual values as the first agruments and expected as the second.

PR-URL: #27907
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
  • Loading branch information
@m0rtyn @ChALkeR
m0rtyn authored and ChALkeR committed May 27, 2019
commit d6cc6ab0376d5dd6a644313154ad84d94be58b2d
10 changes: 5 additions & 5 deletions test/parallel/test-http2-origin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ const ca = readKey('fake-startcom-root-cert.pem', 'binary');
client.on('origin', mustCall((origins) => {
const check = checks.shift();
originSet.push(...check);
deepStrictEqual(originSet, client.originSet);
deepStrictEqual(client.originSet, originSet);
deepStrictEqual(origins, check);
countdown.dec();
}, 2));
Expand All @@ -121,7 +121,7 @@ const ca = readKey('fake-startcom-root-cert.pem', 'binary');

client.on('origin', mustCall((origins) => {
originSet.push(...check);
deepStrictEqual(originSet, client.originSet);
deepStrictEqual(client.originSet, originSet);
deepStrictEqual(origins, check);
client.close();
server.close();
Expand All @@ -148,11 +148,11 @@ const ca = readKey('fake-startcom-root-cert.pem', 'binary');
const client = connect(origin, { ca });

client.on('origin', mustCall((origins) => {
deepStrictEqual([origin, 'https://foo.org'], client.originSet);
deepStrictEqual(client.originSet, [origin, 'https://foo.org']);
const req = client.request({ ':authority': 'foo.org' });
req.on('response', mustCall((headers) => {
strictEqual(421, headers[':status']);
deepStrictEqual([origin], client.originSet);
strictEqual(headers[':status'], 421);
deepStrictEqual(client.originSet, [origin]);
}));
req.resume();
req.on('close', mustCall(() => {
Expand Down