Skip to content

tty: add color support for mosh #27843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aditya1906 wants to merge 5 commits into from
Closed

tty: add color support for mosh #27843

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8020450
lib: add color support for mosh
aditya1906 May 23, 2019
43ae57e
lib: add comma in the object
aditya1906 May 23, 2019
f020e1c
lib: remove space after mosh key in object
aditya1906 May 23, 2019
b2a8e28
lib: correct mosh color support
aditya1906 May 25, 2019
1a666e5
lib: correct mosh color support
aditya1906 May 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/internal/tty.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ const TERM_ENVS = {
'konsole': COLORS_16,
'kterm': COLORS_16,
'mlterm': COLORS_16,
'mosh': COLORS_256,
Copy link
Copy Markdown
Member

@BridgeAR BridgeAR May 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like mosh has true color support?

Copy link
Copy Markdown
Contributor Author

@aditya1906 aditya1906 May 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BridgeAR Mosh has xterm-256 support. It doesn't have truecolor support. I took a look in mosh repository and found that it has xterm-256 support and not truecolor. So shouldn't it be COLORS_256? Or what is the value for xterm-256? Please let me know if I'm mistaken.

Copy link
Copy Markdown
Member

@devsnek devsnek May 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mosh gained truecolor support a few years ago.

Copy link
Copy Markdown
Contributor Author

@aditya1906 aditya1906 May 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @devsnek yes I read that it is now supporting truecolor. So is my commit worth merging to the master branch? Or should it be COLORS_16?

Copy link
Copy Markdown
Member

@devsnek devsnek May 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should change it to COLORS_16m

Copy link
Copy Markdown
Contributor Author

@aditya1906 aditya1906 May 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have corrected the mistake

'putty': COLORS_16,
'st': COLORS_16,
// https://github.com/da-x/rxvt-unicode/tree/v9.22-with-24bit-color
Expand Down