Skip to content

src: remove util-inl.h include in node.h #27804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 1 commit into from
Closed

src: remove util-inl.h include in node.h #27804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: remove util-inl.h include in node.h 
`node.h` may only include public APIs, which `util-inl.h` is not.
There does not seem to be any reason for including it, so remove it,
because otherwise native addon compilation is broken due to us not
shipping the `util-inl.h` header.

Refs: #27631
Fixes: #27803
  • Loading branch information
@addaleax
addaleax committed May 21, 2019
commit 3853b0ce876ba20e613631c4de5f49b0936f4e1b
8 changes: 0 additions & 8 deletions src/node.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,14 +103,6 @@
# endif
#endif

#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
// Internally, do not include util-inl.h into files unless they need it's
// inline definitions.
#else
// Externally, it must be included for backwards API compatibility.
# include <util-inl.h>
#endif

// Forward-declare libuv loop
struct uv_loop_s;

Expand Down