Skip to content

[10.x] libuv 1.28.0 #27776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MylesBorins wants to merge 4 commits into from
Closed

[10.x] libuv 1.28.0 #27776

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b81c82a
test: fix error code typo
cjihrig Mar 31, 2019
934d0cb
deps: upgrade to libuv 1.28.0
cjihrig Apr 15, 2019
50d2ecc
test: move known issue test to parallel
cjihrig Apr 15, 2019
0397aaa
test: unskip copyfile permission test
cjihrig Apr 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: fix error code typo 
PR-URL: #27024
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
@cjihrig @MylesBorins
cjihrig authored and MylesBorins committed May 20, 2019
commit b81c82af8178b97d47ea2c99e0a9dc90a3567c1e
8 changes: 5 additions & 3 deletions test/known_issues/test-fs-copyfile-respect-permissions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,9 @@ function beforeEach() {
fs.chmodSync(dest, '444');

const check = (err) => {
assert.strictEqual(err.code, 'EACCESS');
assert.strictEqual(err.code, 'EACCES');
assert.strictEqual(fs.readFileSync(dest, 'utf8'), 'dest');
return true;
};

return { source, dest, check };
Expand All @@ -39,8 +40,9 @@ function beforeEach() {
// Test promises API.
{
const { source, dest, check } = beforeEach();
assert.throws(async () => { await fs.promises.copyFile(source, dest); },
check);
(async () => {
await assert.rejects(fs.promises.copyFile(source, dest), check);
})();
}

// Test callback API.
Expand Down