src: remove memory_tracker-inl.h from header files

Inline headers should only be included into the .cc files that use them.
nodejs · sam-github · May 22, 2019 · May 17, 2019 · May 17, 2019 · May 22, 2019
commit ad131e224b9519b139fea867a861aef46ee5fc59
diff --git a/src/base_object.h b/src/base_object.h
@@ -24,7 +24,7 @@
 
 #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
 
-#include "memory_tracker-inl.h"
+#include "memory_tracker.h"
 #include "v8.h"
 #include <type_traits>  // std::remove_reference
 

diff --git a/src/cares_wrap.cc b/src/cares_wrap.cc
@@ -23,6 +23,7 @@
 #include "ares.h"
 #include "async_wrap-inl.h"
 #include "env-inl.h"
+#include "memory_tracker-inl.h"
 #include "node.h"
 #include "req_wrap-inl.h"
 #include "util-inl.h"

diff --git a/src/env.cc b/src/env.cc
@@ -1,6 +1,7 @@
 #include "env.h"
 
 #include "async_wrap.h"
+#include "memory_tracker-inl.h"
 #include "node_buffer.h"
 #include "node_context_data.h"
 #include "node_errors.h"

diff --git a/src/heap_utils.cc b/src/heap_utils.cc
@@ -1,4 +1,5 @@
 #include "env-inl.h"
+#include "memory_tracker-inl.h"
 #include "stream_base-inl.h"
 #include "util-inl.h"
 

diff --git a/src/inspector_js_api.cc b/src/inspector_js_api.cc
@@ -1,6 +1,7 @@
 #include "base_object-inl.h"
 #include "inspector_agent.h"
 #include "inspector_io.h"
+#include "memory_tracker-inl.h"
 #include "util-inl.h"
 #include "v8.h"
 #include "v8-inspector.h"

diff --git a/src/inspector_profiler.cc b/src/inspector_profiler.cc
@@ -2,6 +2,7 @@
 #include <sstream>
 #include "base_object-inl.h"
 #include "debug_utils.h"
+#include "memory_tracker-inl.h"
 #include "node_file.h"
 #include "node_internals.h"
 #include "v8-inspector.h"

diff --git a/src/module_wrap.cc b/src/module_wrap.cc
@@ -1,6 +1,7 @@
 #include "module_wrap.h"
 
 #include "env.h"
+#include "memory_tracker-inl.h"
 #include "node_errors.h"
 #include "node_url.h"
 #include "util-inl.h"

diff --git a/src/node.cc b/src/node.cc
@@ -25,6 +25,7 @@
 
 #include "debug_utils.h"
 #include "env-inl.h"
+#include "memory_tracker-inl.h"
 #include "node_binding.h"
 #include "node_internals.h"
 #include "node_main_instance.h"

diff --git a/src/node_config.cc b/src/node_config.cc
@@ -1,4 +1,5 @@
 #include "env-inl.h"
+#include "memory_tracker.h"
 #include "node.h"
 #include "node_i18n.h"
 #include "node_native_module_env.h"

diff --git a/src/node_contextify.cc b/src/node_contextify.cc
@@ -21,6 +21,7 @@
 
 #include "node_contextify.h"
 
+#include "memory_tracker-inl.h"
 #include "node_internals.h"
 #include "node_watchdog.h"
 #include "base_object-inl.h"

diff --git a/src/node_crypto.cc b/src/node_crypto.cc
@@ -32,6 +32,7 @@
 #include "async_wrap-inl.h"
 #include "base_object-inl.h"
 #include "env-inl.h"
+#include "memory_tracker-inl.h"
 #include "string_bytes.h"
 #include "threadpoolwork-inl.h"
 #include "util-inl.h"

diff --git a/src/node_crypto_bio.cc b/src/node_crypto_bio.cc
@@ -20,6 +20,7 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 #include "base_object-inl.h"
+#include "memory_tracker-inl.h"
 #include "node_crypto_bio.h"
 #include "openssl/bio.h"
 #include "util-inl.h"

diff --git a/src/node_file.cc b/src/node_file.cc
@@ -21,6 +21,7 @@
 
 #include "node_file.h"
 #include "aliased_buffer.h"
+#include "memory_tracker-inl.h"
 #include "node_buffer.h"
 #include "node_process.h"
 #include "node_stat_watcher.h"

diff --git a/src/node_http2.cc b/src/node_http2.cc
@@ -1,5 +1,6 @@
 #include "aliased_buffer.h"
 #include "debug_utils.h"
+#include "memory_tracker-inl.h"
 #include "node.h"
 #include "node_buffer.h"
 #include "node_http2.h"

diff --git a/src/node_http_parser_llhttp.cc b/src/node_http_parser_llhttp.cc
@@ -1,6 +1,7 @@
 #define NODE_EXPERIMENTAL_HTTP 1
 
 #include "node_http_parser_impl.h"
+#include "memory_tracker-inl.h"
 #include "node_metadata.h"
 #include "util-inl.h"
 

diff --git a/src/node_http_parser_traditional.cc b/src/node_http_parser_traditional.cc
@@ -2,6 +2,7 @@
 #undef NODE_EXPERIMENTAL_HTTP
 #endif
 
+#include "memory_tracker-inl.h"
 #include "node_http_parser_impl.h"
 #include "node_metadata.h"
 #include "util-inl.h"

diff --git a/src/node_messaging.cc b/src/node_messaging.cc
@@ -2,6 +2,7 @@
 
 #include "async_wrap-inl.h"
 #include "debug_utils.h"
+#include "memory_tracker-inl.h"
 #include "node_contextify.h"
 #include "node_buffer.h"
 #include "node_errors.h"

diff --git a/src/node_perf.cc b/src/node_perf.cc
@@ -1,4 +1,5 @@
 #include "aliased_buffer.h"
+#include "memory_tracker-inl.h"
 #include "node_internals.h"
 #include "node_perf.h"
 #include "node_buffer.h"

diff --git a/src/node_stat_watcher.cc b/src/node_stat_watcher.cc
@@ -19,6 +19,7 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+#include "memory_tracker-inl.h"
 #include "node_stat_watcher.h"
 #include "async_wrap-inl.h"
 #include "env.h"

diff --git a/src/node_trace_events.cc b/src/node_trace_events.cc
@@ -1,5 +1,6 @@
 #include "base_object-inl.h"
 #include "env.h"
+#include "memory_tracker-inl.h"
 #include "node.h"
 #include "node_internals.h"
 #include "node_v8_platform-inl.h"

diff --git a/src/node_worker.cc b/src/node_worker.cc
@@ -1,5 +1,6 @@
 #include "node_worker.h"
 #include "debug_utils.h"
+#include "memory_tracker-inl.h"
 #include "node_errors.h"
 #include "node_buffer.h"
 #include "node_options-inl.h"

diff --git a/src/node_zlib.cc b/src/node_zlib.cc
@@ -19,6 +19,7 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+#include "memory_tracker-inl.h"
 #include "node.h"
 #include "node_buffer.h"
 

diff --git a/src/tls_wrap.cc b/src/tls_wrap.cc
@@ -22,6 +22,7 @@
 #include "tls_wrap.h"
 #include "async_wrap-inl.h"
 #include "debug_utils.h"
+#include "memory_tracker-inl.h"
 #include "node_buffer.h"  // Buffer
 #include "node_crypto.h"  // SecureContext
 #include "node_crypto_bio.h"  // NodeBIO