Skip to content

repl: do not run --eval code if there is none #27587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

repl: do not run --eval code if there is none #27587

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5397a6
repl: do not run --eval code if there is none
addaleax May 6, 2019
9ee9176
lib: restore `global.module` after --eval code is run
addaleax May 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
repl: do not run --eval code if there is none 
`getOptionValue('--eval')` always returns a string, so it is never
loose-equal to `null`. Running eval makes some modifications to the
global object, including setting `module` to a different value, which
we want to avoid if possible.

Refs: #27278
Fixes: #27575
  • Loading branch information
@addaleax
addaleax committed May 6, 2019
commit e5397a6a157ae475b28ef8015ce9577e85e39a54
5 changes: 2 additions & 3 deletions lib/internal/main/repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,9 @@ cliRepl.createInternalRepl(process.env, (err, repl) => {

// If user passed '-e' or '--eval' along with `-i` or `--interactive`,
// evaluate the code in the current context.
const source = getOptionValue('--eval');
if (source != null) {
if (getOptionValue('[has_eval_string]')) {
evalScript('[eval]',
source,
getOptionValue('--eval'),
getOptionValue('--inspect-brk'),
getOptionValue('--print'));
}
22 changes: 22 additions & 0 deletions test/parallel/test-repl-cli-eval.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
'use strict';
const common = require('../common');
const child_process = require('child_process');
const assert = require('assert');

// Regression test for https://github.com/nodejs/node/issues/27575:
// module.id === '<repl>' in the REPL.

for (const extraFlags of [[], ['-e', '42']]) {
const flags = ['--interactive', ...extraFlags];
const proc = child_process.spawn(process.execPath, flags, {
stdio: ['pipe', 'pipe', 'inherit']
});
proc.stdin.write('module.id\n.exit\n');

let stdout = '';
proc.stdout.setEncoding('utf8');
proc.stdout.on('data', (chunk) => stdout += chunk);
proc.stdout.on('end', common.mustCall(() => {
assert(stdout.includes('<repl>'), `stdout: ${stdout}`);
}));
}