Skip to content

src: refactor deprecated UVException usage in pipe-wrap.cc #27562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gengjiawen wants to merge 1 commit into from
+3 −1
Closed

src: refactor deprecated UVException usage in pipe-wrap.cc #27562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: refactor deprecated UVException usage in pipe-wrap.cc
  • Loading branch information
@gengjiawen
gengjiawen committed May 4, 2019
commit 3a43cdb44f385b18e8be5c3628cf76aa59d9c0bc
4 changes: 3 additions & 1 deletion src/pipe_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ using v8::FunctionCallbackInfo;
using v8::FunctionTemplate;
using v8::HandleScope;
using v8::Int32;
using v8::Isolate;
using v8::Local;
using v8::MaybeLocal;
using v8::Object;
Expand Down Expand Up @@ -216,8 +217,9 @@ void PipeWrap::Open(const FunctionCallbackInfo<Value>& args) {
int err = uv_pipe_open(&wrap->handle_, fd);
wrap->set_fd(fd);

Isolate* isolate = env->isolate();
if (err != 0)
env->isolate()->ThrowException(UVException(err, "uv_pipe_open"));
isolate->ThrowException(UVException(isolate, err, "uv_pipe_open"));
}


Expand Down