Skip to content

vm: mark global proxy as side-effect-free #27523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 3 commits into from
Closed

vm: mark global proxy as side-effect-free #27523

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
178dbb8
vm: mark global proxy as side-effect-free
addaleax May 1, 2019
f5a1d12
fixup! vm: mark global proxy as side-effect-free
addaleax May 1, 2019
ad47538
fixup! fixup! vm: mark global proxy as side-effect-free
addaleax May 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fixup! vm: mark global proxy as side-effect-free
  • Loading branch information
@addaleax
addaleax committed May 3, 2019
commit ad47538a0841cebebb8e7563da7fd24599228909
2 changes: 2 additions & 0 deletions test/parallel/test-inspector-vm-global-accessors-getter-sideeffect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,6 @@ session.post('Runtime.evaluate', {
const { exception } = res.exceptionDetails;
assert.strictEqual(exception.className, 'EvalError');
assert(/Possible side-effect/.test(exception.description));

assert(context); // Keep 'context' alive and make linter happy.
});