Skip to content

Mention fs.mkdir's behavior with existing directories in docs. #27505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Gaelan wants to merge 3 commits into from
Closed

Mention fs.mkdir's behavior with existing directories in docs. #27505

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d09603d
doc: clarify behavior of fs.mkdir
Gaelan Apr 30, 2019
26733fc
Apply suggestions from code review
Trott Apr 30, 2019
e39c2b9
wrap, 'error' -> 'rejection'
Gaelan Apr 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: clarify behavior of fs.mkdir
  • Loading branch information
@Gaelan
Gaelan committed Apr 30, 2019
commit d09603d4988255a19859866fdb6e76ce0ce50e0a
8 changes: 6 additions & 2 deletions doc/api/fs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2206,7 +2206,9 @@ are given to the completion callback.

The optional `options` argument can be an integer specifying mode (permission
and sticky bits), or an object with a `mode` property and a `recursive`
property indicating whether parent folders should be created.
property indicating whether parent folders should be created. Calling `fs.mkdir`
Comment thread
Gaelan marked this conversation as resolved.
Outdated
with a path to a directory that exists results in an error an error only
Comment thread
Gaelan marked this conversation as resolved.
Outdated
when `recursive` is false.

```js
// Creates /tmp/a/apple, regardless of whether `/tmp` and /tmp/a exist.
Expand Down Expand Up @@ -4288,7 +4290,9 @@ arguments upon success.

The optional `options` argument can be an integer specifying mode (permission
and sticky bits), or an object with a `mode` property and a `recursive`
property indicating whether parent folders should be created.
property indicating whether parent folders should be created. Calling `fs.mkdir`
Comment thread
Gaelan marked this conversation as resolved.
Outdated
with a path to a directory that exists results in an error an error only
Comment thread
Gaelan marked this conversation as resolved.
Outdated
when `recursive` is false.

### fsPromises.mkdtemp(prefix[, options])
<!-- YAML
Expand Down