Skip to content

test:add common.mustCall to test-dgram-listen-after-bind #27454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhoujiamin wants to merge 1 commit into from
Closed

test:add common.mustCall to test-dgram-listen-after-bind #27454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: add common.mustCall test-dgram-listen-after-bind
  • Loading branch information
zhoujiamin committed Apr 28, 2019
commit f848701581c1e32e39c2ec2b97c38dd3e243ef96
9 changes: 5 additions & 4 deletions test/parallel/test-dgram-listen-after-bind.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

'use strict';
require('../common');
const common = require('../common');
const assert = require('assert');
const dgram = require('dgram');

Expand All @@ -33,12 +34,12 @@ const timer = setTimeout(() => {
socket.close();
}, 100);

socket.on('listening', () => {
socket.on('listening', common.mustCall(() => {
clearTimeout(timer);
fired = true;
socket.close();
});
}));

socket.on('close', () => {
socket.on('close', common.mustCall(() => {
assert(fired, 'listening should fire after bind');
});
}));