Skip to content

test: add mustCall to test-fs-readfile-pipe #27450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tonyhty wants to merge 2 commits into from
Closed

test: add mustCall to test-fs-readfile-pipe #27450

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92c2544
test: add mustCall to test-fs-readfile-pipe
tonyhty Apr 28, 2019
8bb3445
Merge pull request #1 from nodejs/master
tonyhty Apr 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: add mustCall to test-fs-readfile-pipe
  • Loading branch information
@tonyhty
tonyhty committed Apr 28, 2019
commit 92c2544dcef0159035117b9706fea0273e0019d1
8 changes: 4 additions & 4 deletions test/parallel/test-fs-readfile-pipe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ const assert = require('assert');
const fs = require('fs');

if (process.argv[2] === 'child') {
fs.readFile('/dev/stdin', function(er, data) {
fs.readFile('/dev/stdin', common.mustCall(function(er, data) {
assert.ifError(er);
process.stdout.write(data);
});
}));
return;
}

Expand All @@ -47,7 +47,7 @@ const exec = require('child_process').exec;
const f = JSON.stringify(__filename);
const node = JSON.stringify(process.execPath);
const cmd = `cat ${filename} | ${node} ${f} child`;
exec(cmd, function(err, stdout, stderr) {
exec(cmd, common.mustCall(function(err, stdout, stderr) {
assert.ifError(err);
assert.strictEqual(
stdout,
Expand All @@ -58,4 +58,4 @@ exec(cmd, function(err, stdout, stderr) {
'',
`expected not to read anything from stderr but got: '${stderr}'`);
console.log('ok');
});
}));