Skip to content

deps: backport ICU-20558 to fix Intl crasher #27415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srl295 wants to merge 2 commits into from
Closed

deps: backport ICU-20558 to fix Intl crasher #27415

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c369ef0
deps: backport ICU-20558 to fix Intl crasher
srl295 Apr 25, 2019
d93152d
fixup! Some platforms need the full env
refack Apr 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! Some platforms need the full env
  • Loading branch information
@refack
refack committed Apr 25, 2019
commit d93152d8a2fccd423c6ad18a62596defc372e4b3
15 changes: 9 additions & 6 deletions test/parallel/test-intl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,13 @@ if (!common.hasIntl) {
// `ffi` ligature (contraction)
assert.strictEqual(coll.compare('\ufb03', 'ffi'), 0);

// Regression test for https://github.com/nodejs/node/issues/27379
execFile(
process.execPath, ['-p', 'new Date().toLocaleString()'],
{ env: { LC_ALL: 'ja' }, encoding: 'utf-8' },
common.mustCall((e) => assert.ifError(e))
);
{
// Regression test for https://github.com/nodejs/node/issues/27379
const env = { ...process.env, LC_ALL: 'ja' };
execFile(
process.execPath, ['-p', 'new Date().toLocaleString()'],
{ env },
common.mustCall((e) => assert.ifError(e))
);
}
}