Skip to content

assert,deps,repl: fix repl and assert not being able to handle language features properly #27400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 13 commits into from
Closed

assert,deps,repl: fix repl and assert not being able to handle language features properly #27400

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5ad4a1e
deps: add acorn stage-3 plugins
BridgeAR Apr 24, 2019
5bfaab3
assert: use new language features
BridgeAR Apr 24, 2019
dd3f9b1
repl: add new language features to top level await statements
BridgeAR Apr 24, 2019
39a5a38
repl: handle stage-3 language features properly
BridgeAR Apr 24, 2019
c3c18a1
test: add tests for new language features
BridgeAR Apr 24, 2019
022aa35
fixup! test: add tests for new language features
BridgeAR Apr 25, 2019
7a94f40
fixup! deps: add acorn stage-3 plugins
BridgeAR Apr 26, 2019
172d4be
fixup! assert: use new language features
BridgeAR Apr 26, 2019
a4151f0
fixup! repl: add new language features to top level await statements
BridgeAR Apr 26, 2019
4ed5e0b
fixup! repl: handle stage-3 language features properly
BridgeAR Apr 26, 2019
bc81720
fixup! deps: add acorn stage-3 plugins
BridgeAR Apr 26, 2019
0a069a8
fixup! deps: add acorn stage-3 plugins
BridgeAR Apr 26, 2019
7fb74db
doc: update LICENSE locations
BridgeAR Apr 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
assert: use new language features 
This adds new language features to acorn. Otherwise BigInt and other
input would not be parsed correct and would not result in nice error
messages when using simple assert.
  • Loading branch information
@BridgeAR
BridgeAR committed Apr 24, 2019
commit 5bfaab376d8a8465dd9d1cd7896d8dae44a992c7
19 changes: 19 additions & 0 deletions lib/assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,27 @@ function getCode(fd, line, column) {
function parseCode(code, offset) {
// Lazy load acorn.
if (parseExpressionAt === undefined) {
const acorn = require('internal/deps/acorn/acorn/dist/acorn');
({ parseExpressionAt } = require('internal/deps/acorn/acorn/dist/acorn'));
Comment thread
BridgeAR marked this conversation as resolved.
Outdated
const privateMethods =
require('internal/deps/acorn/acorn-private-methods/index');
const bigInt = require('internal/deps/acorn/acorn-bigint/index');
const classFields = require('internal/deps/acorn/acorn-class-fields/index');
const numericSeparator =
require('internal/deps/acorn/acorn-numeric-separator/index');
const staticClassFeatures =
require('internal/deps/acorn/acorn-static-class-features/index');

({ findNodeAround } = require('internal/deps/acorn/acorn-walk/dist/walk'));

const Parser = acorn.Parser.extend(
privateMethods,
bigInt,
classFields,
numericSeparator,
staticClassFeatures
);
parseExpressionAt = Parser.parseExpressionAt.bind(Parser);
}
let node;
let start = 0;
Expand Down