Skip to content

process: reduce the number of internal frames in async stack trace #27392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 3 commits into from
Closed

process: reduce the number of internal frames in async stack trace #27392

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef8b228
process: reduce the number of internal frames in async stack trace
joyeecheung Apr 24, 2019
3def28d
fixup! process: reduce the number of internal frames in async stack t…
joyeecheung Apr 24, 2019
c354c2c
fixup! fixup! process: reduce the number of internal frames in async …
joyeecheung Apr 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fixup! process: reduce the number of internal frames in async … 
…stack trace
  • Loading branch information
@joyeecheung
joyeecheung committed Apr 25, 2019
commit c354c2cea5123dfac05c65276f24f9cf17e00167
11 changes: 7 additions & 4 deletions test/message/async_error_eval_cjs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
'use strict';

require('../common');
const fixtures = require('../common/fixtures');
const errorModule = fixtures.path('async-error.js');
const { spawnSync } = require('child_process');

const main = `'use strict';
const four = require('../common/fixtures')
.readSync('async-error.js')
.toString()
.split('\n')
.slice(2, -2)
.join('\n');

const four = require('${errorModule}');
const main = `${four}

async function main() {
try {
Expand Down
10 changes: 5 additions & 5 deletions test/message/async_error_eval_cjs.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Error: test
at one (*fixtures*async-error.js:4:9)
at two (*fixtures*async-error.js:17:9)
at async three (*fixtures*async-error.js:20:3)
at async four (*fixtures*async-error.js:24:3)
at async main ([eval]:7:5)
at one ([eval]:2:9)
at two ([eval]:15:9)
at async three ([eval]:18:3)
at async four ([eval]:22:3)
at async main ([eval]:28:5)