Skip to content

timers: do less work in insert #27345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
apapirovski wants to merge 3 commits into from
Closed

timers: do less work in insert #27345

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21190b5
timers: do less work in insert
apapirovski Apr 22, 2019
33b3eb4
timers: fix refresh for expired timers
apapirovski Apr 22, 2019
d249fc2
fixup: ref/unref should still work when destroyed
apapirovski May 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: ref/unref should still work when destroyed
  • Loading branch information
@apapirovski
apapirovski committed Dec 13, 2019
commit d249fc238be34d039863d479cc7bf80269c7fc03
12 changes: 7 additions & 5 deletions lib/internal/timers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,23 +207,25 @@ Timeout.prototype.refresh = function() {
};

Timeout.prototype.unref = function() {
if (this[kRefed] && !this._destroyed) {
if (this[kRefed]) {
this[kRefed] = false;
decRefCount();
if (!this._destroyed)
decRefCount();
}
return this;
};

Timeout.prototype.ref = function() {
if (!this[kRefed] && !this._destroyed) {
if (!this[kRefed]) {
this[kRefed] = true;
incRefCount();
if (!this._destroyed)
incRefCount();
}
return this;
};

Timeout.prototype.hasRef = function() {
return !!(this[kRefed] && !this._destroyed);
return this[kRefed];
};

function TimersList(expiry, msecs) {
Expand Down