Skip to content

src: implement minimal v8 snapshot integration #27321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 10 commits into from
Closed

src: implement minimal v8 snapshot integration #27321

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
076c31f
src: allow creating NodeMainInstance that does not own the isolate
joyeecheung Apr 19, 2019
e354795
src: implement IsolateData serialization and deserialization
joyeecheung Apr 18, 2019
de02be6
tools: implement node_mksnapshot
joyeecheung Apr 18, 2019
52c5c05
src: enable snapshot with per-isolate data
joyeecheung Apr 18, 2019
8248be6
src: enable context snapshot after running per-context scripts
joyeecheung Apr 20, 2019
3055cb1
fixup! tools: implement node_mksnapshot
joyeecheung Apr 21, 2019
2ac1d81
src: use std::vector<size_t> instead of IndexArray
joyeecheung Apr 21, 2019
1e0210b
fixup! src: enable context snapshot after running per-context scripts
joyeecheung Apr 22, 2019
0324fe3
fixup! src: allow creating NodeMainInstance that does not own the iso…
joyeecheung Apr 22, 2019
90b5d8d
fixup! tools: implement node_mksnapshot
joyeecheung Apr 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: enable context snapshot after running per-context scripts 
At build time, snapshot the context after running per-context scripts
in the main instance, and in the final build, deserialize the
context in the main instance.

This provides a ~5% in the misc/startup benchmark when the instance
is launched within a process that runs test/fixtures/semicolon.js.
  • Loading branch information
@joyeecheung
joyeecheung committed Apr 20, 2019
commit 8248be6a8e6606ffc7aeebc2fbec4cbcec98c8f6
8 changes: 7 additions & 1 deletion src/node_main_instance.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ using v8::Local;
using v8::Locker;
using v8::SealHandleScope;

const size_t NodeMainInstance::kNodeContextIndex = 0;

NodeMainInstance::NodeMainInstance(Isolate* isolate,
uv_loop_t* event_loop,
MultiIsolatePlatform* platform,
Expand Down Expand Up @@ -171,9 +173,13 @@ std::unique_ptr<Environment> NodeMainInstance::CreateMainEnvironment(
isolate_->GetHeapProfiler()->StartTrackingHeapObjects(true);
}

Local<Context> context = NewContext(isolate_);
Local<Context> context;
if (deserialize_mode_) {
context =
Context::FromSnapshot(isolate_, kNodeContextIndex).ToLocalChecked();
SetIsolateUpForNode(isolate_, IsolateSettingCategories::kErrorHandlers);
} else {
context = NewContext(isolate_);
}

CHECK(!context.IsEmpty());
Expand Down
2 changes: 2 additions & 0 deletions src/node_main_instance.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@ class NodeMainInstance {
static const IndexArray* GetIsolateDataIndexes();
static v8::StartupData* GetEmbeddedSnapshotBlob();

static const size_t kNodeContextIndex;
Comment thread
joyeecheung marked this conversation as resolved.
Outdated

private:
NodeMainInstance(const NodeMainInstance&) = delete;
NodeMainInstance& operator=(const NodeMainInstance&) = delete;
Expand Down
3 changes: 3 additions & 0 deletions tools/snapshot/snapshot_builder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,9 @@ std::string SnapshotBuilder::Generate(
HandleScope scope(isolate);
creator.SetDefaultContext(Context::New(isolate));
isolate_data_indexes = main_instance->isolate_data()->Serialize(&creator);

size_t index = creator.AddContext(NewContext(isolate));
CHECK_EQ(index, NodeMainInstance::kNodeContextIndex);
}

// Must be out of HandleScope
Expand Down