Skip to content

deps: patch V8 to 7.4.288.21 #27265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmarchini wants to merge 2 commits into from
Closed

deps: patch V8 to 7.4.288.21 #27265

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
827ded9
deps: patch V8 to 7.4.288.21
mmarchini Apr 16, 2019
e1dad2c
test: fix postmortem metadata test
mmarchini Apr 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: fix postmortem metadata test 
Recent changes to spawnSync (#23027)
broke our V8 postmortem tests since the output from nm was larger than
the new default maxBuffer for spawnSync. Changing the maxBuffer to
Infinity fixes the issue.
  • Loading branch information
@mmarchini
mmarchini committed Apr 16, 2019
commit e1dad2cb35575a3e6eb6fe9abbe2801f634de884
2 changes: 1 addition & 1 deletion test/v8-updates/test-postmortem-metadata.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ if (common.isAIX)
if (common.isOpenBSD)
common.skip('no v8 debug symbols on OpenBSD');

const nm = spawnSync('nm', args);
const nm = spawnSync('nm', args, { maxBuffer: Infinity });

if (nm.error && nm.error.errno === 'ENOENT')
common.skip('nm not found on system');
Expand Down