Skip to content

zlib: remove usage of require('util') #27180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
moogacs wants to merge 15 commits into from
Closed

zlib: remove usage of require('util') #27180

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
4fcf84a
zlib: remove usage of require('util')
moogacs Apr 10, 2019
d6317d0
module: remove usage of require('util')
dnlup Mar 20, 2019
2a51ae4
test: cover thenables when we check for promises
Nov 7, 2018
1a67c99
stream: remove dead code
marcosc90 Apr 7, 2019
06c803d
test: pass null params to napi_create_function()
Mar 29, 2019
72f4a83
build: tidy up additional libraries on Windows
richardlau Apr 8, 2019
5b9e570
lib: add signal name validator
cjihrig Apr 8, 2019
44a3acb
report: improve signal name validation
cjihrig Apr 8, 2019
547576f
src: always use diagnostic file sequence number
cjihrig Apr 8, 2019
47f5cc1
lib: faster FreeList
apapirovski Mar 30, 2019
29d0b43
benchmark: fix http headers benchmark
apapirovski Mar 30, 2019
655c90b
net: inline maybeDestroy()
lpinca Apr 8, 2019
35677fd
repl: remove usage of require('util')
moogacs Apr 11, 2019
175e8c2
Merge branch 'mooga-branch' of https://github.com/moogacs/node into m…
moogacs Apr 11, 2019
c2d2799
repl: remove usage of require('util')
moogacs Apr 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
benchmark: fix http headers benchmark 
PR-URL: #27021
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@apapirovski @danbev
apapirovski authored and danbev committed Apr 11, 2019
commit 29d0b4342654eeb76a6cd429298d988a59733bf6
4 changes: 3 additions & 1 deletion benchmark/http/headers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ function main({ len, n }) {
'Transfer-Encoding': 'chunked',
};

const Is = [ ...Array(n / len).keys() ];
// TODO(BridgeAR): Change this benchmark to use grouped arguments when
// implemented. https://github.com/nodejs/node/issues/26425
const Is = [ ...Array(Math.max(n / len, 1)).keys() ];
const Js = [ ...Array(len).keys() ];
for (const i of Is) {
headers[`foo${i}`] = Js.map(() => `some header value ${i}`);
Expand Down