Skip to content

Fix some clang-tidy issue and small refactor #27152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
refack merged 2 commits into from
Apr 11, 2019
Merged

Fix some clang-tidy issue and small refactor #27152

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
845a621
src: use macro instead of magic number for fd
gengjiawen Apr 9, 2019
ee7daf7
src: remove redundant string initialization
gengjiawen Apr 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
src: use macro instead of magic number for fd 
PR-URL: #27152
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@gengjiawen @refack
gengjiawen authored and refack committed Apr 11, 2019
commit 845a6214f842f3a5220f4bf4f209c0f5b25d48b5
8 changes: 5 additions & 3 deletions src/node_report_utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,15 +192,17 @@ void WalkHandle(uv_handle_t* h, void* arg) {
if (rc == 0) {
writer->json_keyvalue("fd", static_cast<int>(fd_v));
switch (fd_v) {
case 0:
case STDIN_FILENO:
writer->json_keyvalue("stdio", "stdin");
break;
case 1:
case STDOUT_FILENO:
writer->json_keyvalue("stdio", "stdout");
break;
case 2:
case STDERR_FILENO:
writer->json_keyvalue("stdio", "stderr");
break;
default:
break;
}
}
}
Expand Down