Skip to content

repl: properly handle uncaughtException #27151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 2 commits into from
Closed

repl: properly handle uncaughtException #27151

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbd8eec
repl: properly handle uncaughtException
BridgeAR May 17, 2018
488d03a
fixup! repl: properly handle uncaughtException
BridgeAR May 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! repl: properly handle uncaughtException
  • Loading branch information
@BridgeAR
BridgeAR committed May 6, 2019
commit 488d03a73b6be4135be3955919712389280253c9
4 changes: 3 additions & 1 deletion test/parallel/test-repl-uncaught-exception-async.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ r.write(
r.close();

setTimeout(() => {
Copy link
Copy Markdown
Member

@Trott Trott May 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to use process.on('exit', ...) instead of setTimeout()? That will avoid a possible race condition, or if not that, at least the appearance of a possible race condition.

Copy link
Copy Markdown
Member Author

@BridgeAR BridgeAR May 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to verify the timing. Using process.on('exit', ...) has no timing guarantees.

const len = process.listenerCount('uncaughtException');
process.removeAllListeners('uncaughtException');
assert.strictEqual(len, 0);
assert(/ERR_INVALID_REPL_INPUT.*(?!Type)RangeError: abc/s.test(accum));
assert.strictEqual(process.listenerCount('uncaughtException'), 0);
}, 2);
Comment thread
BridgeAR marked this conversation as resolved.