Skip to content

build: V8 gyp files fixes #27148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
refack wants to merge 6 commits into from
Closed

build: V8 gyp files fixes #27148

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
76b64d3
build: rename v8 PCH files and add new 1/2
refack Mar 31, 2019
d933bd1
build: rename v8 PCH files and add new 2/2
refack Mar 31, 2019
22858fa
build: include PCH dir when using PCH
refack Apr 12, 2019
a601890
build: V8 workaround for MSVC 14.20 bug
refack Apr 8, 2019
34eac84
build: V8 toolchain.gypi dedup and comment
refack Apr 8, 2019
5501305
build: move tourqe and inspector codegen
refack Apr 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
build: rename v8 PCH files and add new 1/2
  • Loading branch information
@refack
refack committed Apr 12, 2019
commit 76b64d3f581b8f3600d965ba02907ac1f88651cf
0 tools/msvs/pch/v8_pch.cc → tools/v8_gypfiles/pch/v8_base_pch.cc
View file
Open in desktop
File renamed without changes.
0 tools/msvs/pch/v8_pch.h → tools/v8_gypfiles/pch/v8_base_pch.h
View file
Open in desktop
File renamed without changes.
8 changes: 4 additions & 4 deletions tools/v8_gypfiles/v8.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,8 +398,8 @@
},
],
['OS=="win"', {
'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
'msvs_precompiled_header': 'pch/v8_base_pch.h',
'msvs_precompiled_source': 'pch/v8_base_pch.cc',
'sources': [
'<(_msvs_precompiled_header)',
'<(_msvs_precompiled_source)',
Expand Down Expand Up @@ -2026,8 +2026,8 @@
],
}],
['OS=="win"', {
'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
'msvs_precompiled_header': 'pch/v8_base_pch.h',
'msvs_precompiled_source': 'pch/v8_base_pch.cc',
'sources': [
'<(_msvs_precompiled_header)',
'<(_msvs_precompiled_source)',
Expand Down