lib: enforce the use of Object from primordials#27146
Closed
targos wants to merge 1 commit into
Closed
Conversation
Collaborator
Collaborator
BridgeAR
approved these changes
Apr 9, 2019
joyeecheung
approved these changes
Apr 9, 2019
Collaborator
Collaborator
bnoordhuis
approved these changes
Apr 9, 2019
addaleax
approved these changes
Apr 9, 2019
jasnell
approved these changes
Apr 10, 2019
devsnek
approved these changes
Apr 10, 2019
2 tasks
Contributor
|
Landed in 908292c. |
danbev
pushed a commit
that referenced
this pull request
Apr 12, 2019
PR-URL: #27146 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
This was referenced Apr 23, 2019
|
I just wanted to say thank you for this fix! 🙇 ❤️ Much appreciated. Bumped up against this issue on an older node version due to a userspace monkey-patch (of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.