Skip to content

test: print child stderr in test-http-chunk-problem#27117

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:chunk-problem
Closed

test: print child stderr in test-http-chunk-problem#27117
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:chunk-problem

Conversation

@addaleax

@addaleax addaleax commented Apr 6, 2019

Copy link
Copy Markdown
Member

This helps with debugging test failures.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

This helps with debugging test failures.
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 6, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 9, 2019
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@addaleax

addaleax commented Apr 9, 2019

Copy link
Copy Markdown
Member Author

Landed in d141330

@addaleax addaleax closed this Apr 9, 2019
@addaleax addaleax deleted the chunk-problem branch April 9, 2019 19:56
addaleax added a commit that referenced this pull request Apr 9, 2019
This helps with debugging test failures.

PR-URL: #27117
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants