Skip to content

lib: use safe methods from primordials #27096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 3 commits into from
Closed

lib: use safe methods from primordials #27096

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b55ce8
lib: use safe methods from primordials
targos Apr 5, 2019
5504368
fixup! lib: use safe methods from primordials
targos Apr 5, 2019
0ea900a
Apply suggestions from mscdex
mscdex Apr 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! lib: use safe methods from primordials
  • Loading branch information
@targos
targos committed Apr 5, 2019
commit 5504368f03be5fa8dd188475dd8abe0ad4ad152e
2 changes: 1 addition & 1 deletion lib/internal/modules/esm/translators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ translators.set('commonjs', async function commonjsStrategy(url, isMain) {
return cached;
}
const module = CJSModule._cache[
isWindows ? StringPrototype.Replace(pathname, winSepRegEx, '\\') : pathname
isWindows ? StringPrototype.replace(pathname, winSepRegEx, '\\') : pathname
];
if (module && module.loaded) {
const exports = module.exports;
Expand Down