Skip to content

dns: refactor internal/dns/promises.js #27081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

dns: refactor internal/dns/promises.js #27081

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1bed5f
dns: refactor internal/dns/promises.js
Trott Apr 4, 2019
d3c7421
dns: do not indicate invalid IPs are IPv6
Trott Apr 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/internal/dns/promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const {
} = require('internal/dns/utils');
const { codes, dnsException } = require('internal/errors');
const { toASCII } = require('internal/idna');
const { isIP, isIPv4, isLegalPort } = require('internal/net');
const { isIP, isLegalPort } = require('internal/net');
const {
getaddrinfo,
getnameinfo,
Expand All @@ -31,7 +31,7 @@ function onlookup(err, addresses) {
return;
}

const family = this.family ? this.family : isIPv4(addresses[0]) ? 4 : 6;
const family = this.family ? this.family : isIP(addresses[0]);
this.resolve({ address: addresses[0], family });
}

Expand All @@ -48,7 +48,7 @@ function onlookupall(err, addresses) {

addresses[i] = {
address,
family: family ? family : isIPv4(addresses[i]) ? 4 : 6
family: family ? family : isIP(addresses[i])
};
}

Expand Down