Skip to content

src: check uv_fs_close() return value #26967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjihrig merged 1 commit into from
Mar 31, 2019
Merged

src: check uv_fs_close() return value #26967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: check uv_fs_close() return value 
Coverity was complaining about not checking the return value.

PR-URL: #26967
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
@cjihrig
cjihrig committed Mar 31, 2019
commit bb98f271815f6f1357c3c7178a3367d439c44029
2 changes: 1 addition & 1 deletion src/module_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ inline Maybe<uv_file> OpenDescriptor(const std::string& path) {

inline void CloseDescriptor(uv_file fd) {
uv_fs_t fs_req;
uv_fs_close(nullptr, &fs_req, fd, nullptr);
CHECK_EQ(0, uv_fs_close(nullptr, &fs_req, fd, nullptr));
uv_fs_req_cleanup(&fs_req);
}

Expand Down