Skip to content

test: add known_issues test for fs.copyFile() #26939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 3 commits into from
Closed

test: add known_issues test for fs.copyFile() #26939

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b8fcee
test: add known_issues test for fs.copyFile()
Trott Mar 27, 2019
c84a732
fixup! test: add known_issues test for fs.copyFile()
Trott Mar 29, 2019
d15753a
fixup! fixup! test: add known_issues test for fs.copyFile()
Trott Mar 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fixup! test: add known_issues test for fs.copyFile()
  • Loading branch information
@Trott
Trott committed Mar 29, 2019
commit d15753a09333043db9af34ea3f119ce62eaa94d1
50 changes: 36 additions & 14 deletions test/known_issues/test-fs-copyfile-respect-permissions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,39 @@ const assert = require('assert');
const fs = require('fs');
const path = require('path');

const source = path.join(tmpdir.path, 'source');
const dest = path.join(tmpdir.path, 'dest');

fs.writeFileSync(source, 'source');
fs.writeFileSync(dest, 'dest');
fs.chmodSync(dest, '444');

assert.throws(() => { fs.copyFileSync(source, dest); },
{ code: 'EACCESS' });

fs.copyFile(source, dest, common.mustCall((err) => {
assert.strictEqual(err.code, 'EACCESS');
assert.strictEqual(fs.readFileSync(dest, 'utf8'), 'dest');
}));
let n = 0;

function beforeEach() {
n++;
const source = path.join(tmpdir.path, `source${n}`);
const dest = path.join(tmpdir.path, `dest${n}`);
fs.writeFileSync(source, 'source');
fs.writeFileSync(dest, 'dest');
fs.chmodSync(dest, '444');

const check = (err) => {
assert.strictEqual(err.code, 'EACCESS');
assert.strictEqual(fs.readFileSync(dest, 'utf8'), 'dest');
};

return { source, dest, check };
}

// Test synchronous API.
{
const { source, dest, check } = beforeEach();
assert.throws(() => { fs.copyFileSync(source, dest); }, check);
}

// Test promises API.
{
const { source, dest, check } = beforeEach();
assert.throws(async () => { await fs.promises.copyFile(source, dest); },
check);
}

// Test callback API.
{
const { source, dest, check } = beforeEach();
fs.copyFile(source, dest, common.mustCall(check));
}