Skip to content

v8.16.0 proposal #26933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MylesBorins merged 34 commits into from
Apr 16, 2019
Merged

v8.16.0 proposal #26933

Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
a1aff28
deps: cherry-pick 525b396 from V8 upstream
psmarshall Dec 14, 2018
b17819d
doc: update the http.request.setTimeout docs to be accurate
jbunton-atlassian Dec 19, 2018
fbafe8d
test: fix test-repl-envvars
addaleax Dec 26, 2018
759a018
n-api: add API for asynchronous functions
Jun 17, 2018
c5a11dc
n-api: fix compiler warning
cjihrig Jun 29, 2018
3675059
n-api: guard against cond null dereference
Jul 18, 2018
67b6e0d
src: fix may be uninitialized warning in n-api
mhdawson Jul 19, 2018
09b88aa
n-api: remove idle_running from TsFn
Jul 27, 2018
902b079
n-api: clean up thread-safe function
Aug 11, 2018
6b7cccc
doc: fix optional parameters in n-api.md
Sep 21, 2018
fe43282
n-api: add missing handle scopes
danbev Oct 31, 2018
60db455
test: mark test_threadsafe_function/test as flaky
gireeshpunathil Nov 29, 2018
d4b6643
test: mark test-cli-node-options flaky on arm
Trott Dec 14, 2018
f6ff8c5
test: fix module loading error for AIX 7.1
richardlau Jan 9, 2019
e936907
build: set `-blibpath:` for AIX
richardlau Jan 11, 2019
1a9582b
tools: allow input for TTY tests
addaleax Sep 24, 2018
ea5628e
process: allow reading from stdout/stderr sockets
addaleax Sep 24, 2018
c56f3ed
test: add stdin writable regression test
addaleax Sep 24, 2018
b4c5435
test: add process.stdin.end() TTY regression test
mcollina Sep 17, 2018
44609d1
n-api: restrict exports by version
kfarnung Dec 7, 2017
d6ffabc
n-api: mark thread-safe function as stable
Jan 22, 2019
1d86261
http: attach reused parser to correct domain
Jan 11, 2019
ac9b8f7
http: fix error check in `Execute()`
mscdex Feb 5, 2019
2b2ad96
n-api: finalize during second-pass callback
Feb 7, 2019
6352288
build: add loader path to rpath for cctest
rubys Sep 29, 2018
c07ba96
build: skip cctest on Windows shared lib build
yhwang Jul 24, 2018
91620b8
tls: fix legacy SecurePair session resumption
bnoordhuis Mar 5, 2019
7573b55
tls: fix legacy SecurePair clienthello race window
bnoordhuis Mar 5, 2019
97cc0fc
deps: V8: cherry-pick 3cc6919
Feb 1, 2019
3128cb7
test: avoid running fsync on directory on AIX
jBarz Jun 13, 2018
eaf474c
test: shared lib build doesn't handle SIGPIPE
yhwang Mar 7, 2018
705935d
assert: fix backport regression
BridgeAR Apr 12, 2019
d3de1ed
n-api: improve performance creating strings
anthony-tuininga Mar 4, 2019
5f93cf7
2019-04-16, Version 8.16.0 'Carbon' (LTS)
MylesBorins Mar 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
n-api: add missing handle scopes 
Currently when building with --debug
test/addons-napi/test_threadsafe_function will error:

$  out/Debug/node test/addons-napi/test_threadsafe_function/test.js
FATAL ERROR: v8::HandleScope::CreateHandle()
  Cannot create a handle without a HandleScope
 1: 0x10004e287 node::DumpBacktrace(__sFILE*) [node/out/Debug/node]
 2: 0x1000cd37b node::Abort() [/node/out/Debug/node]
 3: 0x1000cd69f node::OnFatalError(char const*, char const*)
    [/node/out/Debug/node]
 4: 0x1004df0b1 v8::Utils::ReportApiFailure(char const*, char const*)
    [/nodejs/node/out/Debug/node]
 5: 0x100a8c0a9 v8::internal::HandleScope::Extend(
        v8::internal::Isolate*)
    [/node/out/Debug/node]
 6: 0x1004e4229 v8::EmbedderDataFor(v8::Context*,
                                    int, bool,
                                    char const*)
    [/node/out/Debug/node]
 7: 0x1004e43fa v8::Context::SlowGetAlignedPointerFromEmbedderData(int)
    [/node/out/Debug/node]
 8: 0x10001c26b v8::Context::GetAlignedPointerFromEmbedderData(int)
    [/node/out/Debug/node]
 9: 0x1000144ea node::Environment::GetCurrent(v8::Local<v8::Context>)
    [/node/out/Debug/node]
10: 0x1000f49e2 napi_env__::node_env() const
    [/node/out/Debug/node]
11: 0x1000f9885
    (anonymous namespace)::v8impl::ThreadSafeFunction::
        CloseHandlesAndMaybeDelete(bool)
    [/node/out/Debug/node]
12: 0x1000fb34f (anonymous namespace)::v8impl::ThreadSafeFunction::
        DispatchOne()
    [/node/out/Debug/node]
13: 0x1000fb129
    (anonymous namespace)::v8impl::ThreadSafeFunction::
        IdleCb(uv_idle_s*)
    [/node/out/Debug/node]
14: 0x1011a1b69 uv__run_idle
    [/node/out/Debug/node]
15: 0x101198179 uv_run
    [/node/out/Debug/node]
16: 0x1000dfca1
    node::Start(...)
    [/node/out/Debug/node]
17: 0x1000dae50 node::Start(...)
    [/node/out/Debug/node]
18: 0x1000da56f node::Start(int, char**)
    [/node/out/Debug/node]
19: 0x10141112e main
    [/node/out/Debug/node]
20: 0x100001034 start
    [/node/out/Debug/node]
Abort trap: 6

This commit adds two HandleScope's, one to CloseHandlesAndMaybeDelete
and one to the lambda.

SlowGetAlignedPointerFromEmbedderData will only be called for debug
builds:
https://github.com/v8/v8/blob/2ef0aa662fe907a1b36ac1abe7d77ad2bcd27733
/include/v8.h#L10440-L10447

Backport-PR-URL: #25002
PR-URL: #24011
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
  • Loading branch information
@danbev @rvagg
danbev authored and rvagg committed Feb 28, 2019
commit fe4328252a95f8096dd559d981bcab26a39dd70a
2 changes: 2 additions & 0 deletions src/node_api.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1097,6 +1097,7 @@ class ThreadSafeFunction : public node::AsyncResource {
}

void CloseHandlesAndMaybeDelete(bool set_closing = false) {
v8::HandleScope scope(env->isolate);
if (set_closing) {
node::Mutex::ScopedLock lock(this->mutex);
is_closing = true;
Expand All @@ -1114,6 +1115,7 @@ class ThreadSafeFunction : public node::AsyncResource {
ThreadSafeFunction* ts_fn =
node::ContainerOf(&ThreadSafeFunction::async,
reinterpret_cast<uv_async_t*>(handle));
v8::HandleScope scope(ts_fn->env->isolate);
uv_close(
reinterpret_cast<uv_handle_t*>(&ts_fn->idle),
[] (uv_handle_t* handle) -> void {
Expand Down