Skip to content

fix and improve flaky test-https-connect-localport #26881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 4 commits into from
Closed

fix and improve flaky test-https-connect-localport #26881

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dad3deb
test: move test-https-connect-localport to sequential
Trott Mar 23, 2019
0afa99b
test: use common.PORT instead of hardcoded number
Trott Mar 23, 2019
5348b10
test: replace localhost IP with 'localhost' for TLS conformity
Trott Mar 23, 2019
277ede3
test: refactor test-https-connect-localport
Trott Mar 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: refactor test-https-connect-localport 
Use arrow functions for callbacks. Replace uses of `this` with explicit
variables. Add a trailing comma in a multiline object literal
declaration.
  • Loading branch information
@Trott
Trott committed Mar 23, 2019
commit 277ede3b9e6ebcbae196339147f44da14a279b21
14 changes: 8 additions & 6 deletions test/sequential/test-https-connect-localport.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,21 +9,23 @@ const https = require('https');
const assert = require('assert');

{
https.createServer({
const server = https.createServer({
cert: fixtures.readKey('agent1-cert.pem'),
key: fixtures.readKey('agent1-key.pem'),
}, common.mustCall(function(req, res) {
this.close();
}, common.mustCall((req, res) => {
server.close();
res.end();
})).listen(0, 'localhost', common.mustCall(function() {
const port = this.address().port;
}));

server.listen(0, 'localhost', common.mustCall(() => {
const port = server.address().port;
const req = https.get({
host: 'localhost',
pathname: '/',
port,
family: 4,
localPort: common.PORT,
rejectUnauthorized: false
rejectUnauthorized: false,
}, common.mustCall(() => {
assert.strictEqual(req.socket.localPort, common.PORT);
assert.strictEqual(req.socket.remotePort, port);
Expand Down