Skip to content

test: do not require flags when executing a file #26858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 6 commits into from
Closed

test: do not require flags when executing a file #26858

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e51d722
test: do not require flags when executing a file
BridgeAR Mar 22, 2019
e5e3d0d
fixup! test: do not require flags when executing a file
BridgeAR Mar 24, 2019
88ccbcd
fixup! test: do not require flags when executing a file
BridgeAR Mar 26, 2019
9a8748c
test: move hasCrypto check
BridgeAR Mar 27, 2019
cda4a8c
fixup! test: do not require flags when executing a file
BridgeAR Mar 27, 2019
56576c4
fixup! test: do not require flags when executing a file
BridgeAR Mar 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion test/common/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,10 @@ if (process.argv.length === 2 &&
// If the binary is build without `intl` the inspect option is
// invalid. The test itself should handle this case.
(process.features.inspector || !flag.startsWith('--inspect'))) {
throw new Error(`Test has to be started with the flag: '${flag}'`);
const args = [...flags, ...process.execArgv, ...process.argv.slice(1)];
const options = { encoding: 'utf8', stdio: 'inherit' };
const result = spawnSync(process.execPath, args, options);
process.exit(result.signal || result.status);
}
}
}
Expand Down