Skip to content

tools: update capitalized-comments eslint rule #26849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 6 commits into from
Closed

tools: update capitalized-comments eslint rule #26849

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c50ec6b
benchmark,doc,lib: capitalize more comments
BridgeAR Mar 22, 2019
c029bfe
tools: update capitalize-comments eslint rule
BridgeAR Mar 22, 2019
08661fb
fixup! benchmark,doc,lib: capitalize more comments
BridgeAR Mar 24, 2019
f92d92b
fixup! tools: update capitalize-comments eslint rule
BridgeAR Mar 24, 2019
00b4ff0
fixup! tools: update capitalize-comments eslint rule
BridgeAR Mar 24, 2019
3de5713
fixup! benchmark,doc,lib: capitalize more comments
BridgeAR Mar 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tools: update capitalize-comments eslint rule 
This strictens the rule to apply from 20 characters on instead of
from 30.
  • Loading branch information
@BridgeAR
BridgeAR committed Mar 25, 2019
commit c029bfe688a9b8d31a87a17c37913bdd99912f20
4 changes: 2 additions & 2 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,9 @@ module.exports = {
'brace-style': ['error', '1tbs', { allowSingleLine: true }],
'capitalized-comments': ['error', 'always', {
line: {
// Ignore all lines that have less characters than 30 and all lines that
// Ignore all lines that have less characters than 20 and all lines that
// start with something that looks like a variable name or code.
ignorePattern: '^.{0,30}$|^ [a-z]+ ?[0-9A-Z_.(/=:[#-]|^ std',
ignorePattern: '^.{0,20}$|^ [a-z]+ ?[0-9A-Z_.(/=:[#-]|^ std',
Comment thread
BridgeAR marked this conversation as resolved.
Outdated
ignoreInlineComments: true,
ignoreConsecutiveComments: true,
},
Expand Down