Skip to content

tls: add debugging to native TLS code #26843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 3 commits into from
Closed

tls: add debugging to native TLS code #26843

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b7f3206
tls: add CHECK for impossible condition
addaleax Mar 21, 2019
46cc977
tls: add debugging to native TLS code
addaleax Mar 21, 2019
322bcb3
fixup! tls: add debugging to native TLS code
addaleax Mar 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
tls: add CHECK for impossible condition
  • Loading branch information
@addaleax
addaleax committed Mar 21, 2019
commit b7f32069ec88c3a6e90dbc60ccffd843e0d5144b
8 changes: 4 additions & 4 deletions src/tls_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,10 +747,10 @@ void TLSWrap::OnStreamRead(ssize_t nread, const uv_buf_t& buf) {
return;
}

if (ssl_ == nullptr) {
EmitRead(UV_EPROTO);
return;
}
// DestroySSL() is the only thing that un-sets ssl_, but that also removes
// this TLSWrap as a stream listener, so we should not receive OnStreamRead()
// calls anymore.
CHECK(ssl_);

// Commit the amount of data actually read into the peeked/allocated buffer
// from the underlying stream.
Expand Down