Skip to content

small misc change in src folder 19-03-20 #26815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gengjiawen wants to merge 6 commits into from
Closed

small misc change in src folder 19-03-20 #26815

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
257be5a
src: delete unreachable code in heap_utils.cc
gengjiawen Mar 20, 2019
431363c
src: tidy up include headers in env.cc
gengjiawen Mar 20, 2019
555cfe2
src: delete unused field in class ModuleWrap
gengjiawen Mar 20, 2019
9d724fd
src: use deleted function for class BaseObject
gengjiawen Mar 20, 2019
ba40403
src: fix task release in cares_wrap.cc
gengjiawen Mar 20, 2019
3a885a8
src: delete useless code in cares_wrap.cc
gengjiawen Mar 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: use deleted function for class BaseObject
  • Loading branch information
@gengjiawen
gengjiawen committed Mar 20, 2019
commit 9d724fd842865f23e3268d625b5b4d1ff1705f90
4 changes: 2 additions & 2 deletions src/base_object.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ class BaseObject : public MemoryRetainer {
inline BaseObject(Environment* env, v8::Local<v8::Object> object);
inline ~BaseObject() override;

BaseObject() = delete;

// Returns the wrapped object. Returns an empty handle when
// persistent.IsEmpty() is true.
inline v8::Local<v8::Object> object() const;
Expand Down Expand Up @@ -74,8 +76,6 @@ class BaseObject : public MemoryRetainer {
Environment* env);

private:
BaseObject();

v8::Local<v8::Object> WrappedObject() const override;
bool IsRootNode() const override;
static void DeleteMe(void* data);
Expand Down