Skip to content

lib: refactor validators #26809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 9 commits into from
Closed

lib: refactor validators #26809

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
aea5647
lib: rename validateMode to parseMode
BridgeAR Mar 20, 2019
c1d5d17
lib: remove return values from validation functions
BridgeAR Mar 20, 2019
5f76b83
timers: rename validateTimerDuration to getTimerDuration
BridgeAR Mar 20, 2019
0ec9c67
child_process: rename _validateStdtio to getValidStdio
BridgeAR Mar 20, 2019
f1a2bd5
http2: remove side effects from validateSettings
BridgeAR Mar 20, 2019
641e65d
url: refactor validateHostname
BridgeAR Mar 20, 2019
373c45b
http2: rename function for clarity
BridgeAR Mar 20, 2019
047c840
crypto: remove obsolete encoding check
BridgeAR Mar 20, 2019
595fd96
lib: consolidate arrayBufferView validation
BridgeAR Mar 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
crypto: remove obsolete encoding check 
This renames the parameters for clarity and removes the check for
undefined encoding. That will always default to `utf8`.
  • Loading branch information
@BridgeAR
BridgeAR committed Mar 26, 2019
commit 047c840c0212823882d20e8a0989a8d621fa8ddd
10 changes: 5 additions & 5 deletions lib/internal/crypto/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,13 @@ function getDefaultEncoding() {
// This is here because many functions accepted binary strings without
// any explicit encoding in older versions of node, and we don't want
// to break them unnecessarily.
function toBuf(str, encoding) {
if (typeof str === 'string') {
if (encoding === 'buffer' || !encoding)
function toBuf(val, encoding) {
if (typeof val === 'string') {
if (encoding === 'buffer')
encoding = 'utf8';
return Buffer.from(str, encoding);
return Buffer.from(val, encoding);
}
return str;
return val;
}

const getCiphers = cachedResult(() => filterDuplicateStrings(_getCiphers()));
Expand Down