Skip to content

lib: remove util.inherits in tty.js #26797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nissy-dev wants to merge 2 commits into from
Closed

lib: remove util.inherits in tty.js #26797

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f773fbb
lib: remove util.inherits in tty.js
nissy-dev Mar 20, 2019
d18d5ec
fix build error
nissy-dev Mar 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/tty.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@

'use strict';

const { inherits } = require('util');
const net = require('net');
const { TTY, isTTY } = internalBinding('tty_wrap');
const errors = require('internal/errors');
Expand Down Expand Up @@ -61,7 +60,7 @@ function ReadStream(fd, options) {
this.isRaw = false;
this.isTTY = true;
}
inherits(ReadStream, net.Socket);
Object.setPrototypeOf(ReadStream.prototype, net.Socket.prototype);
Comment thread
ZYSzys marked this conversation as resolved.

ReadStream.prototype.setRawMode = function(flag) {
flag = !!flag;
Expand Down Expand Up @@ -106,7 +105,7 @@ function WriteStream(fd) {
this.rows = winSize[1];
}
}
inherits(WriteStream, net.Socket);
Object.setPrototypeOf(WriteStream.prototype, net.Socket.prototype);
Comment thread
ZYSzys marked this conversation as resolved.

WriteStream.prototype.isTTY = true;

Expand Down