Skip to content

process: handle --expose-internals during pre-execution #26759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 2 commits into from
Closed

process: handle --expose-internals during pre-execution #26759

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb928c5
process: handle --expose-internals during pre-execution
joyeecheung Mar 18, 2019
5221820
fixup! process: handle --expose-internals during pre-execution
joyeecheung Mar 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! process: handle --expose-internals during pre-execution
  • Loading branch information
@joyeecheung
joyeecheung committed Mar 19, 2019
commit 52218203d45bc2367ab4d043e49d9a08037a9d4d
2 changes: 1 addition & 1 deletion lib/internal/bootstrap/loaders.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ function NativeModule(id) {
NativeModule.exposeInternals = function() {
for (const [id, mod] of NativeModule.map) {
// Do not expose this to user land even with --expose-internals.
if (id.startsWith('internal/') && id !== loaderId) {
if (id !== loaderId) {
mod.canBeRequiredByUsers = true;
Comment thread
joyeecheung marked this conversation as resolved.
}
}
Expand Down