Skip to content

lib: set properties in error #26752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 3 commits into from
Closed

lib: set properties in error #26752

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b90463
test: remove internal error tests
BridgeAR Mar 18, 2019
c91023c
lib: move extra properties into error creation
BridgeAR Mar 18, 2019
b86767b
fixup! lib: move extra properties into error creation
BridgeAR Mar 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! lib: move extra properties into error creation
  • Loading branch information
@BridgeAR
BridgeAR committed Mar 20, 2019
commit b86767b8a1e3c803efa4923330186af8a5c3cc6d
8 changes: 4 additions & 4 deletions lib/internal/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ function lazyBuffer() {
class SystemError extends Error {
constructor(key, context) {
super();
const prefix = getMessage.call(this, key, []);
const prefix = getMessage(key, [], this);
let message = `${prefix}: ${context.syscall} returned ` +
`${context.code} (${context.message})`;

Expand Down Expand Up @@ -157,7 +157,7 @@ function makeNodeErrorWithCode(Base, key) {
return class NodeError extends Base {
constructor(...args) {
super();
const message = getMessage.call(this, key, args);
const message = getMessage(key, args, this);
Object.defineProperty(this, 'message', {
value: message,
enumerable: false,
Expand Down Expand Up @@ -217,7 +217,7 @@ function E(sym, val, def, ...otherClasses) {
codes[sym] = def;
}

function getMessage(key, args) {
function getMessage(key, args, self) {
const msg = messages.get(key);

if (util === undefined) util = require('util');
Expand All @@ -229,7 +229,7 @@ function getMessage(key, args) {
`Code: ${key}; The provided arguments length (${args.length}) does not ` +
`match the required ones (${msg.length}).`
);
return msg.apply(this, args);
return msg.apply(self, args);
}

const expectedLength = (msg.match(/%[dfijoOs]/g) || []).length;
Expand Down