Skip to content

tools: remove eslint rule no-let-in-for-declaration #26715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gengjiawen wants to merge 1 commit into from
Closed

tools: remove eslint rule no-let-in-for-declaration #26715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
tools: remove eslint rule no-let-in-for-declaration
  • Loading branch information
@gengjiawen
gengjiawen committed Mar 17, 2019
commit 8da554202a040df37443540cd4e491858e80b952
1 change: 0 additions & 1 deletion lib/.eslintrc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ rules:
message: "Use an error exported by the internal/errors module."
# Custom rules in tools/eslint-rules
node-core/require-globals: error
node-core/no-let-in-for-declaration: error
node-core/lowercase-name-for-primitive: error
node-core/non-ascii-character: error
globals:
Expand Down
45 changes: 0 additions & 45 deletions test/parallel/test-eslint-no-let-in-for-declaration.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion test/root.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ parallel/test-eslint-duplicate-requires: SLOW
parallel/test-eslint-eslint-check: SLOW
parallel/test-eslint-inspector-check: SLOW
parallel/test-eslint-lowercase-name-for-primitive: SLOW
parallel/test-eslint-no-let-in-for-declaration: SLOW
parallel/test-eslint-no-unescaped-regexp-dot: SLOW
parallel/test-eslint-number-isnan: SLOW
parallel/test-eslint-prefer-assert-iferror: SLOW
Expand Down
38 changes: 0 additions & 38 deletions tools/eslint-rules/no-let-in-for-declaration.js
View file
Open in desktop

This file was deleted.