Skip to content

v6.17.1 proposal #26684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BethGriggs merged 8 commits into from
Apr 3, 2019
Merged

v6.17.1 proposal #26684

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
aedc712
src: fix bootstrap_node on bsd
sylkat Sep 2, 2018
ad62971
doc: document that addMembership must be called once in a cluster
jasnell Oct 19, 2018
1371a6f
doc: simplify CODE_OF_CONDUCT.md
Trott Oct 31, 2018
9ba5fd6
build: only check REPLACEME & DEP...X for releases
rvagg May 11, 2017
b5d4649
test: fix test-repl-envvars
addaleax Dec 26, 2018
8080a9b
http: fix error check in `Execute()`
mscdex Feb 5, 2019
c9d21a0
build: set `-blibpath:` for AIX
richardlau Jan 11, 2019
576c2bf
2019-04-03, Version 6.17.1 'Boron' (LTS)
BethGriggs Mar 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix test-repl-envvars 
In 180f865, the test was changed
so that the `env` argument of `createInternalRepl()` also contained
external environment variables, because keeping them can be necessary
for spawning processes on some systems.

However, this test does not spawn new processes, and relies on the
fact that the environment variables it tests are not already set
(and fails otherwise); therefore, reverting to the original state
should fix this.

Fixes: #21451
Fixes: nodejs/build#1377
Refs: #25219

PR-URL: #25226
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
@addaleax @BethGriggs
addaleax authored and BethGriggs committed Mar 7, 2019
commit b5d464955aeb6d5c8ccfebaa58159d4724830692
2 changes: 1 addition & 1 deletion test/parallel/test-repl-envvars.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const tests = [
];

function run(test) {
const env = Object.assign({}, process.env, test.env);
const env = test.env;
const expected = test.expected;
const opts = {
terminal: true,
Expand Down