Skip to content

fs: remove experimental warning for fs.promises #26581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 3 commits into from
Closed

fs: remove experimental warning for fs.promises #26581

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5cad376
fs: remove experimental warning for fs.promises
addaleax Mar 11, 2019
6956fa3
fixup! fs: remove experimental warning for fs.promises
addaleax Mar 12, 2019
b9154d3
fixup! fs: remove experimental warning for fs.promises
addaleax Mar 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fs: remove experimental warning for fs.promises 
This has been warning for long enough, without any API changes
in the last few months.
  • Loading branch information
@addaleax
addaleax committed Mar 30, 2019
commit 5cad37619a46fd8ef642f0dfdf732374748abfe8
5 changes: 1 addition & 4 deletions lib/fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1932,11 +1932,8 @@ Object.defineProperties(fs, {
configurable: true,
enumerable: false,
get() {
if (promises === null) {
Copy link
Copy Markdown
Member

@jdalton jdalton Mar 12, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this property enumerable: true now that it's no longer experimental.
It also no longer needs to be a getter.

Copy link
Copy Markdown
Member Author

@addaleax addaleax Mar 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdalton Thanks, done :)

if (promises === null)
promises = require('internal/fs/promises');
process.emitWarning('The fs.promises API is experimental',
'ExperimentalWarning');
}
return promises;
}
}
Expand Down