Skip to content

[v10.x backport] deps: v8, backport coverage fixes #26579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bcoe wants to merge 4 commits into from
Closed

[v10.x backport] deps: v8, backport coverage fixes #26579

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13126ec
[v10.x backport] deps: v8, backport coverage fixes
Mar 11, 2019
de7ffec
chore: attempted fix for compiler error
Mar 11, 2019
40b8f96
chore: address slight differences in test structure
Mar 12, 2019
50893ee
chore: fix typo in tests
Mar 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: attempted fix for compiler error
  • Loading branch information
bcoe committed Mar 11, 2019
commit de7ffec2fcd808e9cbcd78c2f6f34e510c5fb00c
8 changes: 0 additions & 8 deletions deps/v8/src/zone/zone-list-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,14 +128,6 @@ void ZoneList<T>::Iterate(Visitor* visitor) {
for (int i = 0; i < length_; i++) visitor->Apply(&data_[i]);
}

template <typename T>
bool ZoneList<T>::Contains(const T& elm) const {
for (int i = 0; i < length_; i++) {
if (data_[i] == elm) return true;
}
return false;
}

template <typename T>
template <typename CompareFunction>
void ZoneList<T>::Sort(CompareFunction cmp) {
Expand Down
7 changes: 6 additions & 1 deletion deps/v8/src/zone/zone.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,12 @@ class ZoneList final {
// Drops all but the first 'pos' elements from the list.
INLINE(void Rewind(int pos));

inline bool Contains(const T& elm) const;
inline bool Contains(const T& elm) const {
for (int i = 0; i < length_; i++) {
if (data_[i] == elm) return true;
}
return false;
}

// Iterate through all list entries, starting at index 0.
template <class Visitor>
Expand Down