Skip to content

fs: improve mode validation #26575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 3 commits into from
+41 −31
Closed

fs: improve mode validation #26575

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ed5538
fs: improve mode validation
BridgeAR Mar 10, 2019
b82b9e5
fixup! fs: improve mode validation
BridgeAR Mar 13, 2019
bbeed06
fixup! fs: improve mode validation
BridgeAR Mar 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! fs: improve mode validation
  • Loading branch information
@BridgeAR
BridgeAR committed Mar 13, 2019
commit b82b9e50d95678330f1481c6568dc90496dd0615
4 changes: 2 additions & 2 deletions test/parallel/test-fs-lchmod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ assert.throws(() => fs.lchmod(f, {}), { code: 'ERR_INVALID_CALLBACK' });
const errObj = {
code: 'ERR_OUT_OF_RANGE',
name: 'RangeError [ERR_OUT_OF_RANGE]',
message: 'The value of "mode" is out of range. It must be >= 0 && < ' +
`4294967296. Received ${input}`
message: 'The value of "mode" is out of range. It must be >= 0 && <= ' +
`4294967295. Received ${input}`
};

promises.lchmod(f, input, () => {})
Expand Down