Skip to content

test: fix syntax error in test-dns-idna2008.js when failing #26570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
refack merged 1 commit into from
Mar 12, 2019
Merged

test: fix syntax error in test-dns-idna2008.js when failing #26570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix syntax error in test-dns-idna2008.js when failing 
Fixes a bug I introduced in 9613221

PR-URL: #26570
Refs: #25870
Refs: #26473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
@refack
refack committed Mar 12, 2019
commit f77555f792e8515192d6fe973d7c4e1532da9d5c
8 changes: 5 additions & 3 deletions test/internet/test-dns-idna2008.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,15 @@ dns.lookup(fixture.hostname, mustCall((err, address) => {
assert.strictEqual(address, fixture.expectedAddress);
}));

dns.promises.lookup(fixture.hostname).then(mustCall(({ address }) => {
dns.promises.lookup(fixture.hostname).then(({ address }) => {
assert.strictEqual(address, fixture.expectedAddress);
}).catch((err) => {
}, (err) => {
if (err && err.errno === 'ESERVFAIL') {
assert.ok(err.message.includes('queryA ESERVFAIL straße.de'));
} else {
throw err;
}
Comment thread
refack marked this conversation as resolved.
Outdated
}));
}).finally(mustCall());

dns.resolve4(fixture.hostname, mustCall((err, addresses) => {
assert.ifError(err);
Expand Down