Skip to content

various fix in lib #26562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gengjiawen wants to merge 3 commits into from
+8 −8
Closed

various fix in lib #26562

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2cc0cfb
http: delay ret declaration in method _flushOutput
gengjiawen Mar 10, 2019
4bd2635
repl: remove redundant initialization
gengjiawen Mar 10, 2019
d768c5c
lib: make lowerProto scope more clear
gengjiawen Mar 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
lib: make lowerProto scope more clear
  • Loading branch information
@gengjiawen
gengjiawen committed Mar 10, 2019
commit d768c5c6f2d50968b603a8996d1c3b55f3e06b54
5 changes: 3 additions & 2 deletions lib/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,10 +250,11 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) {
}
}

var proto = protocolPattern.exec(rest);
let proto = protocolPattern.exec(rest);
let lowerProto;
if (proto) {
proto = proto[0];
var lowerProto = proto.toLowerCase();
lowerProto = proto.toLowerCase();
this.protocol = lowerProto;
Comment thread
gengjiawen marked this conversation as resolved.
rest = rest.slice(proto.length);
}
Expand Down