Skip to content

benchmark: add "byGroup" config option #26559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BeniCheni wants to merge 10 commits into from
Closed

benchmark: add "byGroup" config option #26559

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
51a6b82
benchmark: add byGroup option in benchmark configs
BeniCheni Mar 10, 2019
a6fc43c
benchmark: adapt byGroup option with buffer-form-by-group.js benchmark
BeniCheni Mar 10, 2019
272fa07
doc: add byGroup option and example in writing-and-running-benchmarks.md
BeniCheni Mar 10, 2019
ccce103
refactor: update const variables and comment in benchmark common.js
BeniCheni Mar 10, 2019
883c90a
refactor: update let variable in benchmark buffer-from-by-group.js
BeniCheni Mar 10, 2019
0bfdd66
benchmark: add process.env.NODEJS_BENCHMARK_BYPASS_GROUP support
BeniCheni Mar 19, 2019
7e802ab
benchmark: correct typo of enqueueConfigs function in benchmark common
BeniCheni Mar 19, 2019
b961b02
benchmark: update code format in benchmark/common.js
BeniCheni Mar 19, 2019
81ffaec
benchmark: rename variables in benchmark/common.js
BeniCheni Mar 19, 2019
6d847e8
benchmark: rename parsedArgs variables in benchmark/common.js
BeniCheni Mar 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
benchmark: correct typo of enqueueConfigs function in benchmark common
  • Loading branch information
@BeniCheni
BeniCheni committed Mar 20, 2019
commit 7e802abfc500174f44359b37c3087bab3392797b
4 changes: 2 additions & 2 deletions benchmark/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ function Benchmark(fn, configs, options) {
}
};

const enqueuConfigs = (configs) => {
const enqueueConfigs = (configs) => {
// Parse job-specific configuration from the command line arguments
const parsed_args = this._parseArgs(process.argv.slice(2), configs);
this.options = parsed_args.cli;
Expand All @@ -52,7 +52,7 @@ function Benchmark(fn, configs, options) {
enqueueConfigsInGroups(configs);
}
} else {
enqueuConfigs(configs);
enqueueConfigs(configs);
}
Copy link
Copy Markdown
Member

@lundibundi lundibundi Feb 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be simplified to

const parseConfig = (config) => {
  const parsedArgs = this._parseArgs(process.argv.slice(2), config);
  this.options = parsedArgs.cli;
  this.extra_options = parsedArgs.extra;
  this.queue = [ ...this.queue, ...this._queue(this.options) ];
}

if (byGroup) {
  let usedConfigs = Object.values(configs);
  if (process.env.NODEJS_BENCHMARK_BYPASS_GROUP)
    usedConfigs = usedConfigs[0];
  usedConfigs.forEach(parseConfig);
} else {
  parseConfig(configs);
}


// The configuration of the current job, head of the queue
Expand Down